saltstack/salt

Human-readable expire in user.present

Open

#55,983 opened on Jan 27, 2020

View on GitHub
 (2 comments) (4 reactions) (0 assignees)Python (13,710 stars) (5,508 forks)batch import
Featuregood first issue

Description

According to user.present documentation the expire property of user.present should be specified as an integer as

Date that account expires, represented in days since epoch (January 1, 1970)

To make it more human-readable I want to be able to specify it as a string with an ISO 8601 date (e.g. "2020-01-27").

Instead of:

foo-expires:
  user.present:
    - name: foo
    - expire: 18288

I would like to be able to have:

foo-expires:
  user.present:
    - name: foo
    - expire: 2020-01-27

That would make it much easier to understand when a user expires.

Contributor guide

Tech stack
python
Domain
backendinfrastructure
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Python basicsSalt module structuredatetime handling
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75
Research direction
The issue requests adding ISO 8601 string support for the expire parameter in salt/states/user.py. Examine the user.present function and its argument parsing. Use Python's datetime module to convert an ISO date string to days since epoch. Check existing tests in tests/unit/states/test user.py and consider adding a helper function. The issue has no assignee or linked PR, so it's open for contribution.