saltstack/salt

chattr in file.managed applied at the wrong time

Open

#55,489 opened on Dec 2, 2019

View on GitHub
 (9 comments) (0 reactions) (0 assignees)Python (13,710 stars) (5,508 forks)batch import
buggood first issueseverity-medium

Description

Description of Issue

when using file.managed, an immutable file causes an error. When using attrs: "" - that removes immutable, but only AFTER the content change (that fails, immutable is never removed)

Setup

echo "aa" > /somefile chattr +i /somefile

Steps to Reproduce Issue

state: some file: file.managed: - name: /somefile - attr: "" - content: "xx"

salt runs with: Failed to commit change: [Errno 1] Operation not permitted if the file content is ok, immutable flag gets properly removed

Versions Report

Salt Version: Salt: 2018.3.4

Dependency Versions: cffi: 1.6.0 cherrypy: unknown dateutil: Not Installed docker-py: Not Installed gitdb: 0.6.4 gitpython: 1.0.1 ioflo: Not Installed Jinja2: 2.7.2 libgit2: 0.26.3 libnacl: Not Installed M2Crypto: 0.28.2 Mako: Not Installed msgpack-pure: Not Installed msgpack-python: 0.5.6 mysql-python: 1.2.5 pycparser: 2.14 pycrypto: 2.6.1 pycryptodome: Not Installed pygit2: 0.26.4 Python: 2.7.5 (default, Oct 30 2018, 23:45:53) python-gnupg: Not Installed PyYAML: 3.11 PyZMQ: 15.3.0 RAET: Not Installed smmap: 0.9.0 timelib: Not Installed Tornado: 4.2.1 ZMQ: 4.1.4

System Versions: dist: centos 7.6.1810 Core locale: UTF-8 machine: x86_64 release: 4.15.0-54-generic system: Linux version: CentOS Linux 7.6.1810 Core

Contributor guide

Tech stack
pythonshell
Domain
backenddevops
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
basic Salt state knowledgeunderstanding of chattr
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Investigate the `file.managed` state in Salt, specifically in `salt/states/file.py`. The issue is that `attrs` are applied after content changes, causing failure when the file is immutable. The fix should ensure attrs are set before managing content when the file is immutable. Check the order of operations in the ` manage file` function and consider making the attribute change occur first or handling immutable files specially.
chattr in file.managed applied at the wrong time · saltstack/salt#55489 | Good First Issue