sahat/satellizer

The library thinks that when we are on a browser cordova will be undefined.

Open

#977 opened on Sep 24, 2016

View on GitHub
 (2 comments) (0 reactions) (0 assignees)TypeScript (1,110 forks)github user discovery
hacktoberfest

Repository metrics

Stars
 (7,803 stars)
PR merge metrics
 (PR metrics pending)

Description

I think the reason that the library does not work on a browser with IONIC / cordova is the fact that it assumes that when we are on a browser this.$window['cordova'] will be undefined.

But actually this is not the case in an ionic project. On a browser platform, after we build and upload the application on a server cordova exists! So, if I am right and please correct me if I am wrong, in order to be able to use the library, you will need to replace in every if else condition (this.$window['cordova'] && this.$window['cordova'].platformId === "browser) in order to be able to work on a browser platform.

Contributor guide

Research direction
Search the codebase for all occurrences of `this.$window['cordova']` and update each condition to also handle the case when `cordova.platformId === 'browser'` in Ionic environments. This will allow the library to work correctly in a browser when served from a server after an Ionic build.
Tech stack
javascriptangular
Domain
authenticationfrontendmobile dev
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
AngularJSGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75