sahat/satellizer

Impossible to login on iOS Safari/Chrome with 0.15.5, keeps redirecting to domain.com/login.

Open

#956 opened on Sep 11, 2016

View on GitHub
 (7 comments) (2 reactions) (0 assignees)TypeScript (1,110 forks)github user discovery
hacktoberfest

Repository metrics

Stars
 (7,803 stars)
PR merge metrics
 (PR metrics pending)

Description

This has become worse as I upgraded from 0.13.5 to 0.15.5.

Error found using Web Inspector:

Error: OAuth redirect has occurred but no query or hash parameters were found. They were either not set during the redirect, or were removed—typically by a routing library—before Satellizer could read it.

Update

Setting the timer to 200[1] milliseconds from 500 millionseconds makes it work on iOS Safari 100%. But not on Google Chrome , although success rate increases.

[1] Line 587 of satellizer.js.

Okay, guys, now even I am confused. What exactly is happening here and what is the solution @sahat .

Something somewhere is polling every 500 milli, causing the problem, but setting it to 200 milli makes a whole lot of a difference. I am curious. I think we might be close to fixing this...Let's investigate....

Contributor guide

Research direction
Investigate the polling interval for OAuth redirect detection in Satellizer. The issue suggests that reducing the polling interval from 500ms to 200ms resolves the problem on iOS. Examine the code at line 587 of satellizer.js and understand why a longer interval causes the redirect parameters to be missed. Consider browser specific behavior on iOS for OAuth popups.
Tech stack
javascript
Domain
authentication
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
AngularJS
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75