AggregateFlowFrames with custom markers

Open Beginner friendly
#19 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
65/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Stale
Tech stack
r
Domain
data

Research direction

Start in the AggregateFlowFrames function, focusing on the diffNumberChannels check around line 288 and the GetChannels conversion around line 304. Verify the behavior with custom markers and confirm that the channel-count warning is no longer produced when the inputs contain equivalent custom markers.

Written by the indexing model from the issue text.

Description

Hi Sofie

I saw in the function AggregateFlowFrames that if you use custom markers in the channels parameter, you will bump into the warning: "Files do not contain the same number of channels/markers. Zeros might have been imputed for missing values." This is due to the fact that the custom markers are not yet converted to channels with the GetChannels function before the diffNumberChannels check (line 288). This conversion only happens afterwards (line 304).

Kind regards
Artuur

Dominant language
R
Stars
37
Forks
9
PR merge metrics
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from saeyslab/FlowSOM

All issues in saeyslab/FlowSOM

Similar issues

More R issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.