saber-notes/saber

Define "1.0x" zoom to be when the page width and screen width are equal

Open

#674 opened on May 30, 2023

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Dart (4,456 stars) (322 forks)batch import
buggood first issue

Description

Describe the bug

If I zoom above 1.0, then the black side margins become bigger and bigger. When zooming to 5.0, the black side margin is almost half the screen size.

To reproduce

  1. Any note
  2. zoom to 5.0 (just any value above 1.0)
  3. go to the far left/right of the note
  4. see how black part of screen is very large

Expected behavior

I would expect that the black side margins remain constant for all zoom levels above 1.0. Then, less movement of the note is needed and the user experience is much better. It seems to me that the side margins are specified by a fixed value. I would suggest to make it dependent on the zoom level.

Saber version

v0.12.7 (Google Play Store)

Device

  • Device: Samsung Galaxy Tab S6
  • OS: LineageOS 20 (Android 13)

Anything else?

No response

Contributor guide

Tech stack
dartflutter
Domain
mobile
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Familiarity with Flutter layoutUnderstanding of zoom transformations
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65
Research direction
The issue describes that black side margins increase with zoom level. The expected behavior is constant margins. To fix, investigate how zoom level is applied to margins in the note rendering code. Likely files: 'lib/canvas/' or similar. Check if margins are scaled with zoom; they should remain constant. The one comment on the issue might provide additional context. After identifying the scaling logic, adjust to keep margins fixed regardless of zoom.