saadq/resumake.io

Source code display doesn't work on iOS... or maybe it does, but doesn't signal type to user?

Open

#12 opened on Jun 2, 2017

View on GitHub
 (5 comments) (0 reactions) (0 assignees)TeX (3,559 stars) (485 forks)batch import
bughelp wanted

Description

It looks like you're providing binary data of some kind in response to the generate source button. In mobile safari, I get a binary file with a URL like blob:https://latexresu.me/a833e5be-1f05-46b5-b1c6-b445d5ad6082 --- shouldn't it just be a plain text .tex file?

Actually, poking around, I see that the very last commit just set that to application/zip. That wasn't clear to me from the interface---is source code download multiple files? Maybe it would be helpful to send the user a signal that they should be downloading a zip, like give it a filename or something?

Contributor guide

Tech stack
javascriptnodejs
Domain
frontendbackend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
basic HTTP headersJavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Investigate the source code download endpoint in the backend (likely Node.js/Express). The last commit (8c4bfdd) changed the Content Type to application/zip. Determine if the response should be a plain text .tex file or a zip of multiple files. Consider setting proper Content Disposition header to signal download type on iOS Safari. Look at the route handling '/api/source' or similar in the codebase.