saadpasta/developerFolio

Images in Dark mode look weird

Open

#484 opened on Apr 5, 2022

View on GitHub
 (12 comments) (0 reactions) (0 assignees)JavaScript (4,696 stars) (2,351 forks)batch import
good first issuehacktoberfest

Description

When in light mode, all the images which have dark blue shade, like the computer desk or the Dart image looks fine, but in dark mode they aren't visible as they use dark colors and don't dynamically become white or change to a light shade when the website is switched to dark mode. Probably there should be 2 set of images and they need to be toggled with light and dark toggle.

Contributor guide

Tech stack
javascriptreactcsshtml
Domain
frontend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Basic JavaScriptCSS for dark modeImage handling
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65
Research direction
Investigate the current dark mode implementation in the repository (likely using CSS media query or JavaScript toggle). Review comments on issue #484 for any suggested approaches. Identify images that are problematic (e.g., computer desk, Dart image). Consider creating lighter versions of those images and implementing a toggle mechanism that switches between light and dark image sources based on the current theme. Look at how other images are handled in the codebase for consistency.