s-a/iron-node

Electron Helper crashes when refreshing while devtools is paused

Open

#133 opened on Aug 28, 2017

View on GitHub
 (4 comments) (0 reactions) (0 assignees)JavaScript (78 forks)batch import
OS Xelectronhelp wanted

Repository metrics

Stars
 (2,336 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Description

I'm currently working on a nodes project that seems to crash Electron Helper when I hit cmd+R while devtools is paused at a debugger statement.

Steps to Reproduce

The project calls require(' ts-node/require') then require('index.ts') to start my app, which might be relevant to reproduce. The debugger statement resides in the index.ts (which is transpired and loaded with inlined source maps by ts-node.

  1. Launch iron-node within the project folder: iron-node ./index.js
  2. Wait for devtools to pause at a debugger statement.
  3. Hit cmd+R

Expected behavior:

Reloads without issues.

Actual behavior:

Reloads but shows Problem Report for Electron Helper

Reproduces how often:

The crash seems to occur consistently on every reload even after relaunching iron-node and restarting, upgrading iron-node and dependencies, but in rare occasion while testing it sometimes stopped happening without clear cause.

It never happened when I manually pause devtools, as opposed to dynamically pausing by calling debugger, before hitting cmd+R.

At some point when I tried to replicate this by calling debugger from index.js, I could no longer reproduce it, even when I stepped through to the debugger statement in index.ts. I even removed the debugger statement from index.js to revert to the initial scenario and it no longer crashed when dynamically paused from index.ts. I simply don't have a clue what could have changed.

This has been happening for a few months, with different versions of every aspect involved (Iron-node, electron, node, typescript, ts-node, macOS, you name it), and it is not restricted to this one project, but most of my projects will usually require ts-node/require so it remains a potential factor but not necessarily the cause.

Screenshot(s):

Version(s)

{
    "http_parser": "2.7.0",
    "node": "7.9.0",
    "v8": "5.8.283.38",
    "uv": "1.11.0",
    "zlib": "1.2.11",
    "ares": "1.10.1- DEV",
    "modules": "54",
    "openssl": "1.0.2k",
    "electron": "1.7.5",
    "chrome": "58.0.3029.110",
    "atom-shell": "1.7.5",
    "ts-node": "3.3.0"
}

=====================
Notes from ironNode maintainer: You are welcome to add a feature or fix a bug via sending pull request, it'll be incredibly faster than just opening a bug or feature request issue. :fireworks: Thanks!

Sorry: I tried to do some leg work, but I can't seem to figure iron-node's internals enough to debug the issue. But I am available to help you with any troubleshooting or testing you need.

Contributor guide