ryanmcdermott/clean-code-javascript

What about Magic strings?

Open

#122 opened on Jan 12, 2017

View on GitHub
 (13 comments) (0 reactions) (0 assignees)JavaScript (12,469 forks)batch import
help wanted

Repository metrics

Stars
 (94,343 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Do you think that can be good to include something about magic strings?

Bad:

let posts = getPostsFromCategory('sports');

Good:

const categories = {
  sports: 'sports',
  economy: 'economy'
};

let posts = getPostsFromCategory(categories.sports);

Contributor guide