rwf2/Rocket

Allow wildcards in content-type

Open

#583 opened on Mar 11, 2018

View on GitHub
 (6 comments) (5 reactions) (0 assignees)Rust (25,738 stars) (1,645 forks)batch import
enhancementgood first issue

Description

Currently (Rocket version 0.4.0-dev) if you use a wildcard in content-type you will get a warning like this:

warning: 'image/*' is not a known media type
 --> src/handlers/image.rs:5:33
  |
5 | #[post("/image", format = "image/*", data = "<data>")]
  |                                 ^^^^^^^^^

Using wildcard e.g. for images is needed as you do not know what the actual type of the image will be (png, gif, jpg etc.) and you want to handle all of them in the same route.

Contributor guide

Tech stack
rust
Domain
backend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Rust programmingRocket framework basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Investigate how Rocket currently parses and validates media types in the 'format' route attribute. The warning originates from a media type parser that rejects wildcards. Look at the 'rocket codegen' crate's 'format' parsing logic and the 'http' crate's 'MediaType' implementation. Consider proposing a change to allow wildcards by accepting known top level types (e.g., 'image') with any subtype. Check issue comments for prior discussion and any maintainer suggestions.