rwf2/Rocket

(async) Remove or replace typed headers

Open

#1067 opened on Aug 2, 2019

View on GitHub
 (12 comments) (0 reactions) (1 assignee)Rust (25,738 stars) (1,645 forks)batch import
help wanted

Description

Typed headers were removed between hyper 0.10 and hyper 0.12. typed-headers does not appear to have all the headers hyper 0.10 did, but it looks like hyperx and headers might.

Options:

  • Re-export headers from one or the other library - this is what we did with hyper 0.10
  • Remove typed header support - this is currently implemented in the async branch; only the header names are available in hyper and we re-export those.
  • Implement From<X> for Header for every header in one or both of hyperx and typed-headers, perhaps behind a feature flag

Contributor guide

Tech stack
rust
Domain
backendapi
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
RustRockethyper
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
15
Research direction
Investigate the 'hyperx' and 'typed headers' crates to see which has the most complete set of headers that hyper 0.10 had. Review the current async branch implementation that only re exports header names. Consider whether to re export from one library, remove typed header support, or implement From traits behind a feature flag. Consult maintainer comments in the issue for preferred direction.