rust-lang/this-week-in-rust

Add way to change color theme on the site

Open

#3,938 opened on Jan 6, 2023

View on GitHub
 (2 comments) (2 reactions) (0 assignees)HTML (1,932 stars) (1,010 forks)batch import
enhancementhelp wanted

Description

With the addition of a dark mode for the website, the only way for readers to change theme would be to change their OS preferences.

It would be nice to be able to change the color theme directly on the site. Proposed ideas include a tri-state switch or button (maybe like the MDN docs?), but optimally it would be nice to have a setting for choosing dark, light, or the OS default.

See more discussion about this here.

Contributor guide

Tech stack
htmlcssjavascript
Domain
frontend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
None
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85
Research direction
The issue proposes adding a theme toggle for dark/light/OS default. Currently, the site uses OS preference via CSS media query. To implement, you would need to modify the site's layout files (likely in layouts/ or assets/) to include a toggle button and use JavaScript to override the media query or set a class. See the linked discussion at https://github.com/rust lang/this week in rust/issues/2274 for more context. Also check the site's static files for existing theme implementation.
Add way to change color theme on the site · rust-lang/this-week-in-rust#3938 | Good First Issue