rust-lang/this-week-in-rust

Header formatting on email version of TWiR is not line breaking correctly

Open

#3,592 opened on Aug 26, 2022

View on GitHub
 (10 comments) (0 reactions) (0 assignees)HTML (1,932 stars) (1,010 forks)batch import
bughelp wanted

Description

The title image and header of the email are not breaking correctly in the generated HTML code for the TwiR email issue.

The break should be placed after the "This Week in Rust" title image. Instead, the line is currently breaking after the "This" in the text header.

The email code is being generated by the optimize-email Makefile job, which uses the website code (via the make build && make generate-website && make host-content command) to create an email using juice.

<td style="font-family: 'Helvetica Neue', Helvetica, sans-serif;">
  <img class="wrapper-image " src="https://this-week-in-rust.org/images/logo32.png" alt="This Week in Rust" style="width: 30px; vertical-align: bottom; max-width: 100%;" width="30">
  <span class="wrapper-header-01" style="line-height: 27px; font-size: 23px; font-weight: bold; color: #444444;">This Week in Rust</span>
</td>

Narrow window: Screen Shot 2022-08-25 at 6 25 39 PM

Wide window: Screen Shot 2022-08-25 at 6 23 48 PM

Contributor guide

Tech stack
htmlcss
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
CSS basicsHTML email rendering
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75
Research direction
Examine the email generation code in the repository, particularly the Makefile’s `optimize email` target and the associated HTML template. Look for the inline styles that control the img and span elements. Consider adding a clear break (e.g., a <br> or using CSS display block) after the image to ensure proper line breaking. Test with different email widths to verify the fix.