rust-lang/this-week-in-rust

Email publishing codegen script is not formatting correctly

Open

#3,591 opened on Aug 26, 2022

View on GitHub
 (2 comments) (0 reactions) (0 assignees)HTML (1,932 stars) (1,010 forks)batch import
bughelp wanted

Description

The Pelican publishing script used by the Makefile command optimize-email is not picking up TWIR_NEWSLETTER_THEME setting and defaulting to a CSS style that does not match our most recent issues (e.g. 454).

Currently, the workaround for this has been to change pelicanconf.py from:

if '1' == os.environ.get('TWIR_NEWSLETTER_THEME'):
    THEME = 'themes/newsletter'
else:
    THEME = 'themes/rusted'

to:

THEME = 'themes/newsletter'

Contributor guide

Tech stack
pythonhtmlcssshell
Domain
content
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
None
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
The issue is in the This Week in Rust repository, specifically in pelicanconf.py where the environment variable TWIR NEWSLETTER THEME is checked. The fix involves ensuring the script correctly picks up the theme setting when generating the email. The current workaround of directly setting the theme to 'themes/newsletter' suggests a simple code change to read the environment variable properly and apply the correct theme. No linked PRs or maintainer questions were found.