rust-lang/rustfmt

Enhance diff_check with more unicode et al

Open

#5,884 opened on Aug 13, 2023

View on GitHub
 (13 comments) (2 reactions) (1 assignee)Rust (4,893 stars) (760 forks)batch import
E-help-wantedgood first issue

Description

Follow up action item from a topic I raised in https://github.com/rust-lang/rustfmt/pull/5864#issuecomment-1676425492 relative to adding some additional test repos to improve our coverage of string formatting with various characters and encodings.

One suggested repo to include is https://github.com/unicode-org/icu4x as well as some from https://github.com/unicode-rs

I opted to simply mention icu4x as part of this instead of directly adding it because I noticed that repo is using cargo make and I didn't have bandwidth to determine if that'd cause any issues/require any additional changes to our script.

New repos can be wired up by adding a call site with respective args here:

https://github.com/rust-lang/rustfmt/blob/b069aac44ddfdb70d55d9ae40695be44515e5bb0/ci/check_diff.sh#L170-L192

Contributor guide

Tech stack
rustshell
Domain
devopstestingci cd
Issue type
test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
blocked
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
shell scripting basicsfamiliarity with rustfmt
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Review the linked PR comment (#5864) for context. Add a new call to the icu4x repository in ci/check diff.sh around lines 170-192, following the existing pattern. Test the script locally to ensure compatibility with cargo make used by icu4x.