rust-lang/rustfmt

Visual IndentStyle is broken on impl with where clause

Open

#3071 opened on Sep 30, 2018

View on GitHub
 (12 comments) (0 reactions) (1 assignee)Rust (4,893 stars) (760 forks)batch import
I-poor-formattingUO-indent_stylegood first issueonly-with-option

Description

Test code:

struct A<T>
    where T: Send
{
    x: u32,
}

impl<T> A<T> where T: Send
{
    fn foo() {}
}

The impl block is expected to be formatted as:

impl<T> A<T>
    where T: Send
{
    fn foo() {}
}

Everything is ok for indent_style: "Block".

rustfmt version:

rustfmt 0.99.5-nightly (90692a59 2018-09-26)

Contributor guide

Tech stack
rust
Domain
tooling
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
blocked
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Rustrustfmt internals
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
Examine the formatting logic for impl blocks with where clauses in the visual indent style in rustfmt. The relevant code is likely in the formatting module that handles indent style 'Visual'. Check if there is an existing test for this case and review comments from the assignee (jmj0502) for progress. Start by looking at the source code for formatting impl items and where clause handling.