Inconsistent naming for '#'

Open Beginner friendly
#113,159 11 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
64/100
Issue type
Refactor
Clarity
Mostly clear
Activity status
Quiet
Tech stack
rust
Domain
compilers

Research direction

Start in compiler/rustc_lexer/src/lib.rs and search for the Pound token, hash terminology, and n_hashes. Identify the naming convention used around the lexer and make the references consistent; done means the '#' token terminology no longer mixes the two names.

Written by the indexing model from the issue text.

Description

A-docs A-parser T-compiler
Location

compiler/rustc_lexer/src/lib.rs

Summary

# Token is refered to as Pound, but it's also refered to as hash sometimes. n_hashes

This is a really minor problem, but I just wanted to point it out.

Dominant language
Rust
Stars
119k
Forks
16.2k
Avg merge
2d 9h
Merged PRs (30d)
529

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from rust-lang/rust

All issues in rust-lang/rust

Similar issues

More Rust issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.