rust-lang/rust-clippy

Lint x != _ || x != _

Open

#853 opened on Apr 12, 2016

View on GitHub
 (3 comments) (0 reactions) (1 assignee)Rust (10,406 stars) (1,391 forks)batch import
A-lintL-correctnessT-middlegood first issue

Description

Also probably x == _ && x == _. This is either a duplicate (if both _ are equal) or always false (true for the former).

Contributor guide

Tech stack
rust
Domain
tooling
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Rust basicsClippy contribution basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
25
Research direction
Investigate the pattern `x != || x != ` and its equivalence `x == && x == `. Look at existing lints in clippy for similar logical patterns, such as `logic bug` or `comparison chain`. Check the assignee's activity and any linked issues. Determine where to add the new lint in the clippy source (e.g., `clippy lints/src/logic.rs`).