rust-lang/rust-clippy

Inconsistent underscores false positive?

Open

#6,836 opened on Mar 3, 2021

View on GitHub
 (3 comments) (0 reactions) (0 assignees)Rust (10,406 stars) (1,391 forks)batch import
C-enhancementgood first issue

Description

Ok so this is a fun one. cargo fmt doesn't understand astetics of verticals alas ( https://github.com/rust-lang/rustfmt/issues/4710 ), but with the odd trailing _ you can fool cargo fmt into doing the right thing and making things beautiful:

https://github.com/mimblewimble/grin/pull/3572/files

But clippy's not happy with inconsistent underscores. ( https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping )

Is there a better solution than a few trailing underscores? (leading underscores are banned) if not, could clippy not complain about trailing underscores please?

Tables come up a lot in programming so it would be nice to have good ways to format them.

Contributor guide

Tech stack
rust
Domain
toolingdeveloper experience
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Rust programmingbasic understanding of clippy's lint system
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
45
Research direction
Look at the clippy source code for the 'inconsistent digit grouping' lint in clippy lints/src/. Check the linked rustfmt issue #4710 for context on the alignment trick. Determine if changing the lint to allow trailing underscores is feasible and if there are any alternative approaches suggested in the issue discussion.