rust-lang/rust-clippy

upper_case_acronyms complains about full-capital identifiers

Open

#6631 opened on Jan 23, 2021

View on GitHub
 (9 comments) (2 reactions) (1 assignee)Rust (10,406 stars) (1,391 forks)batch import
C-bugI-false-positivegood first issue

Description

Lint name: upper_case_acronyms

I tried this code:

pub enum DIR {}

Checks for camel case name containing a capitalized acronym. but there is no camel-case here, it's literally all uppercase, not sure why this triggers here then....

Contributor guide

Tech stack
rust
Domain
toolingdeveloper experience
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Rustclippy
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
The issue is reproducible with `pub enum DIR {}`. The lint incorrectly flags fully uppercase identifiers. To fix, examine the lint logic in `clippy lints/src/upper case acronyms.rs`. The comments may contain discussion on the expected behavior. Proposed fix: add a check to skip identifiers that are entirely uppercase.