rust-lang/rust-clippy

Lint `unsigned - other_unsigned > 0`

Open

#588 opened on Jan 29, 2016

View on GitHub
 (5 comments) (0 reactions) (0 assignees)Rust (10,406 stars) (1,391 forks)batch import
A-lintL-correctnessS-needs-discussionT-middlegood first issue

Description

Idea from here. Basically, x - y, where x and y are of some unsigned integer type, returns 0 iff x == y, so comparing the difference to 0 is dodgy and should at least be rewritten for clarity.

Contributor guide

Tech stack
rust
Domain
tooling
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Basic RustFamiliarity with clippy's lint structure
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Look at existing lint implementations in clippy, e.g., the `abs` or `overflow` lints. Implement a new lint that catches `x y > 0` where x and y are unsigned. The lint should suggest using `x > y` instead. Reference the Viva64 article for rationale. Check the clippy documentation for adding a new lint.
Lint `unsigned - other_unsigned > 0` · rust-lang/rust-clippy#588 | Good First Issue