rust-lang/rust-clippy

Lint `unsigned - other_unsigned > 0`

Open

#588 opened on Jan 29, 2016

View on GitHub
 (5 comments) (0 reactions) (0 assignees)Rust (1,391 forks)batch import
A-lintL-correctnessS-needs-discussionT-middlegood first issue

Repository metrics

Stars
 (10,406 stars)
PR merge metrics
 (Avg merge 19d 22h) (113 merged PRs in 30d)

Description

Idea from here. Basically, x - y, where x and y are of some unsigned integer type, returns 0 iff x == y, so comparing the difference to 0 is dodgy and should at least be rewritten for clarity.

Contributor guide

Research direction
Implement a new lint that detects `x y > 0` where x and y are unsigned integers, suggesting `x > y` instead. Study existing lint implementations in clippy for patterns.
Tech stack
rust
Domain
tooling
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Rust
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65