rust-lang/rust-clippy

New lint: Prefer mem::take over Vec::split_off(0)

Open

#4,953 opened on Dec 25, 2019

View on GitHub
 (4 comments) (0 reactions) (1 assignee)Rust (1,391 forks)batch import
A-lintS-needs-discussiongood first issue

Repository metrics

Stars
 (10,406 stars)
PR merge metrics
 (Avg merge 19d 22h) (113 merged PRs in 30d)

Description

let mut vec = vec![1,2,3];
let vec2 = vec.split_off(0);

Should be written as

let vec2  = std::mem::take(&mut vec);

Contributor guide

Research direction
Review clippy's lint creation guide. Study existing lints like `manual memcpy`. Implement a lint for `Vec::split off(0)` and add test cases.
Tech stack
rust
Domain
devtools
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
RustGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75