rust-lang/rust-clippy

Support for upcoming `param_attrs` feature

Open

#4474 opened on Aug 30, 2019

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Rust (10,406 stars) (1,391 forks)batch import
C-enhancementE-needs-testS-needs-discussiongood first issue

Description

param_attrs is likely to be stabilized in Rust 1.39

The param_attrs feature is going to allow lint attributes on function, method and closure parameters:

fn foo(
    a: i32,
    #[allow(unused_variables)] b: i32,
) {}

We should review how this feature ties in with our existing lints. Apparently it did not cause any toolstate breakage when it was merged.

Specifically, we should create a list of lints that could benefit from parameter attributes and then update those lints to make use of them (if that's even required).

Contributor guide

Tech stack
rust
Domain
toolingdeveloper experience
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
3-5 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Understanding of Rust's param attrs featureFamiliarity with clippy's lint internals
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
20
Research direction
Review the linked Rust PR (https://github.com/rust lang/rust/pull/64010) to understand the param attrs feature. Then, examine clippy's existing lints to identify which ones could benefit from parameter attributes, such as those checking for unused parameters or style issues. Create a list of affected lints and update them to support the new attribute syntax if needed. No current comments or PRs provide further direction.