rust-lang/rust-clippy

Extract commonly used visitors to utils

Open

#4413 opened on Aug 19, 2019

View on GitHub
 (3 comments) (1 reaction) (0 assignees)Rust (10,406 stars) (1,391 forks)batch import
C-enhancementgood first issue

Description

Both #3427 and #4386 implement a Visitor that walks an expression and searches for a return. This should be de-duplicated.

Maybe there are other Visitors in the Clippy code base, that also do similar things and can be extracted to utils.

Originally posted by @mikerite in https://github.com/rust-lang/rust-clippy/pull/4386#issuecomment-522407926

Contributor guide

Tech stack
rust
Domain
tooling
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
RustClippy internalsVisitor pattern
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
35
Research direction
Examine the linked PRs #3427 and #4386 to understand the duplicated Visitor implementations. Search the Clippy source code (likely in `clippy lints/src/`) for similar Visitors that traverse expressions and check for returns. Extract the common logic into a utility module, perhaps `clippy utils/src/visitors.rs`. Refer to issue comments for further details on which visitors to consolidate.