rust-lang/rust-clippy

Extract commonly used visitors to utils

Open

#4,413 opened on Aug 19, 2019

View on GitHub
 (3 comments) (1 reaction) (0 assignees)Rust (1,391 forks)batch import
C-enhancementgood first issue

Repository metrics

Stars
 (10,406 stars)
PR merge metrics
 (Avg merge 19d 22h) (113 merged PRs in 30d)

Description

Both #3427 and #4386 implement a Visitor that walks an expression and searches for a return. This should be de-duplicated.

Maybe there are other Visitors in the Clippy code base, that also do similar things and can be extracted to utils.

Originally posted by @mikerite in https://github.com/rust-lang/rust-clippy/pull/4386#issuecomment-522407926

Contributor guide

Research direction
Search for visitor implementations in the Clippy codebase that walk expressions and look for returns, then extract them into a shared utility.
Tech stack
rust
Domain
developer experiencetooling
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
Rust
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60