rust-lang/rust-clippy

False positive for boxed local with `wasm_bindgen`

Open

#4,351 opened on Aug 7, 2019

View on GitHub
 (14 comments) (0 reactions) (0 assignees)Rust (1,391 forks)batch import
C-bugI-false-positivegood first issue

Repository metrics

Stars
 (10,406 stars)
PR merge metrics
 (Avg merge 19d 22h) (113 merged PRs in 30d)

Description

wasm_bindgen is a little bit different than the issue that's been resolved with traits. In particular, wasm_bindgen just generates code around the non-trait implemented function, and the only way to use native JS arrays as parameters is to use Box<[...]>.

In general, I think maybe boxed slices should be considered ok for local parameters, as they're conceptually very similar to vectors.

Contributor guide

Research direction
Inspect the clippy lint that triggers for boxed locals and understand the interaction with wasm bindgen's code generation. Determine why boxed slices should be allowed for local parameters in this context.
Tech stack
rust
Domain
tooling
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Rust
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65