rust-lang/rust-clippy

Lint `static mut FOO: T` where `T` has a safe counterpart

Open

#4,070 opened on May 8, 2019

View on GitHub
 (5 comments) (0 reactions) (0 assignees)Rust (1,391 forks)batch import
A-lintL-correctnessgood first issue

Repository metrics

Stars
 (10,406 stars)
PR merge metrics
 (Avg merge 19d 22h) (113 merged PRs in 30d)

Description

There is no reason to ever write static mut FOO: u32. Instead one should use static FOO: AtomicU32 which does the same thing, is just as efficient and requires no unsafe code.

We should lint this for at least

  • u8, u16, u32, u64
  • i8, i16, i32, i64
  • isize, usize
  • bool
  • *mut T

Contributor guide

Research direction
Examine existing lints for static mut, like `static mut refs`, and understand how to check the type of a `static mut` item via rustc's type system. Look at how other lints implement type checks.
Tech stack
rust
Domain
tooling
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
3-5 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
RustGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65