rust-lang/rust-clippy

FR: redundant_field_names should distinguish between all and some fields matching

Open

#3,422 opened on Nov 10, 2018

View on GitHub
 (1 comment) (4 reactions) (1 assignee)Rust (1,391 forks)batch import
C-enhancementL-stylegood first issue

Repository metrics

Stars
 (10,406 stars)
PR merge metrics
 (Avg merge 19d 22h) (113 merged PRs in 30d)

Description

redundant_field_names fires on any field being a match. This impairs readability in cases like this:

let thingy = Thingy {
   calc: big + calculation,
   redundant: redundant,
   other: stuff.into(),
};

As you can see, if you apply the suggestion, you end up with a weird line that is different from the rest. I suggest that the lint be split such that it distinguishes between "all fields are redundant" and "some fields are redundant".

Contributor guide

Research direction
Examine the current `redundant field names` lint implementation in Clippy and modify it to detect whether all fields or only some fields are redundant, then adjust the lint suggestion accordingly.
Tech stack
rust
Domain
tooling
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Rust
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70