rust-lang/rust-clippy

Lint against calling intrinsics that have stable or safe wrappers

Open

#2997 opened on Aug 3, 2018

View on GitHub
 (8 comments) (2 reactions) (0 assignees)Rust (10,406 stars) (1,391 forks)batch import
A-lintL-suggestionL-unnecessarygood first issue

Description

There are some intrinsics that there should be no reason to call. For example core::intrinsics::size_of. This intrinsic is exposed by the safe function core::mem::size_of which should always be called instead.

I would like to suggest a Clippy lint that notices calls to no-reason-to-call intrinsics and recommends the right stable or safe wrapper to call instead.

Contributor guide

Tech stack
rust
Domain
tooling
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic Rust knowledgeUnderstanding of Clippy's lint structureFamiliarity with Rust intrinsics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Research the list of intrinsics that have stable or safe wrappers, starting with core::intrinsics::size of as mentioned in the issue. Look at existing Clippy lints for examples of how to implement a new lint (e.g., in clippy lints/src/). Check the comments in the issue for additional intrinsics suggested by the community. Define a lint that detects direct calls to these intrinsics and suggests the corresponding safe wrapper.