rust-lang/rust-clippy

Iterators: suggest `position()` instead of `enumerate() + find() + .0`

Open

#2282 opened on Dec 20, 2017

View on GitHub
 (5 comments) (3 reactions) (1 assignee)Rust (10,406 stars) (1,391 forks)batch import
A-lintT-middlegood first issue

Description

This is sort of the opposite of #456. I recently wrote let idx = v.iter().enumerate().find(|&(_, &ch)| ch == '|').unwrap().0, when I should have written let idx = v.iter().position(|&ch| ch == '|').unwrap(). I'd have to think a little on the exact rule that should be followed here, but it would be nice if clippy could catch this pattern.

Contributor guide

Tech stack
rust
Domain
developer experiencetooling
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
blocked
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Rust
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
The issue requests a new lint to detect the pattern `enumerate().find().0` and suggest `position()`. It references issue #456 for context. The assignee is GabrielBFern. To implement, one should study existing Clippy lints in the `clippy lints` directory, particularly those related to iterators, and follow the lint creation guidelines.