rust-lang/rust-clippy

Warn if file contains large number of items

Open

#2261 opened on Dec 6, 2017

View on GitHub
 (6 comments) (2 reactions) (0 assignees)Rust (10,406 stars) (1,391 forks)batch import
A-lintL-guidelinesT-ASTgood first issue

Description

Basically a lint that pushes people to factor their code into multiple files. I have no idea exactly how this would be computed, but it'd be nice to have in some form.

Contributor guide

Tech stack
rust
Domain
toolingdeveloper experience
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
3-5 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
needs investigation
Prerequisites
Basic knowledge of RustUnderstanding of Clippy's lint architecture
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
Start by examining existing Clippy lints in the repository, particularly those that count items or inspect file structure. The issue lacks specifics on what constitutes a 'large number of items' and how to compute it; further discussion is needed in the issue to clarify requirements. Potential approaches could involve counting top level items like functions, structs, enums, etc. Review comments in the issue for any additional ideas.