rust-lang/rust-clippy

Lint calling methods that are redundant to deref

Open

#2094 opened on Sep 28, 2017

View on GitHub
 (3 comments) (0 reactions) (1 assignee)Rust (10,406 stars) (1,391 forks)batch import
A-lintL-unnecessaryT-middlegood first issue

Description

For example, vec.as_slice().first() could be just worded as vec.first().

We'd probably want to have a whitelist for this, but in general, calling such methods is redundant.

Contributor guide

Tech stack
rust
Domain
developer experiencetooling
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
blocked
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
RustClippy internalsderef trait
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Review existing lints like `redundant method call` in clippy lints/src/. The issue is assigned and requests a lint for methods redundant due to deref, e.g., `vec.as slice().first()` > `vec.first()`. A whitelist may be needed. Check comments for context.