rust-lang/rust-clippy

lint variable assignments that could be part of a method/field chain

Open

#2035 opened on Sep 9, 2017

View on GitHub
 (6 comments) (0 reactions) (0 assignees)Rust (10,406 stars) (1,391 forks)batch import
A-lintL-unnecessaryT-middlegood first issue

Description

let x = foo.bar;
let y = x.met();

Should be

let y = foo.bar.met();

If x is not used anywhere else

Contributor guide

Tech stack
rust
Domain
tooling
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
3-5 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Rustclippy development
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
The issue requests a new lint that detects variable assignments that could be inlined into method/field chains. To implement this, study existing clippy lints, especially those in the 'methods' or 'assignments' categories. Look at the Rust AST structures for let statements and method calls. The issue has no linked PRs or assignees, so it's open for contribution. Check the clippy contributing guide and search for similar lints like 'needless pass by value' or 'single match' for patterns.