rust-lang/rust-clippy

Extensions to should_assert_eq

Open

#1810 opened on Jun 3, 2017

View on GitHub
 (1 comment) (1 reaction) (1 assignee)Rust (10,406 stars) (1,391 forks)batch import
C-enhancementgood first issue

Description

I found this in the standard library:

assert!(o == owned && b == borrowed)

This should be a case for should_assert_eq. Additionally, it might be nice to have a lint that suggests splitting asserts with && to multiple assert statements, for better debugging.

Contributor guide

Tech stack
rust
Domain
toolingdeveloper experiencetesting
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Rust programmingFamiliarity with clippy's lint systemBasic understanding of should assert eq
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
35
Research direction
Investigate the current implementation of should assert eq in clippy, likely in the 'clippy lints' crate. The issue suggests modifying the lint to handle the pattern `assert!(o == owned && b == borrowed)` and possibly creating a new lint to split `&&` in assertions. Look at existing test files and the lint's documentation. Check if there are any previous attempts or related PRs by searching the issue tracker. The assignee may have left comments or a branch.