rust-lang/rust-clippy

Extensions to should_assert_eq

Open

#1,810 opened on Jun 3, 2017

View on GitHub
 (1 comment) (1 reaction) (1 assignee)Rust (1,391 forks)batch import
C-enhancementgood first issue

Repository metrics

Stars
 (10,406 stars)
PR merge metrics
 (Avg merge 19d 22h) (113 merged PRs in 30d)

Description

I found this in the standard library:

assert!(o == owned && b == borrowed)

This should be a case for should_assert_eq. Additionally, it might be nice to have a lint that suggests splitting asserts with && to multiple assert statements, for better debugging.

Contributor guide

Research direction
Study the existing `should assert eq` lint in the Clippy source to understand its pattern matching. Then modify it to handle logical AND within assert macros. Additionally, research how to create a new lint that suggests splitting assertions with `&&` into multiple assert statements for better debugging.
Tech stack
rust
Domain
testing
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
RustGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65