Expand float_cmp to structs with PartialEq

Repository metrics

Stars

10,406 stars (10,406 stars)

PR merge metrics

Avg merge 19d 22h (Avg merge 19d 22h)113 merged PRs in 30d (113 merged PRs in 30d)

Description

#[derive(PartialEq)]
struct Data {
    v: f64,
}

fn main() {
    let d1 = Data { v: 1.0 };
    let d2 = Data { v: 2.0 };

    // here should be a warning
    println!("{}", d1 == d2);
}

Contributor guide

Research direction

Extend the existing float cmp lint to warn when a struct with float fields and derive(PartialEq) is compared for equality. This involves adding a new case in the lint's visitor that checks for PartialEq implementations on structs containing float fields.

Tech stack

rust

Domain

developer experience

Issue type

Feature

DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.

3

Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.

1-2 days

Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.

Stale

ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.

Clear

Prerequisites

RustClippy internals

Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.

40