rust-lang/rust-clippy

don't fold(..) an Option when you can map_or(..)

Open

#1,658 opened on Apr 3, 2017

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Rust (1,391 forks)batch import
A-lintL-styleT-middlegood first issue

Repository metrics

Stars
 (10,406 stars)
PR merge metrics
 (Avg merge 19d 22h) (113 merged PRs in 30d)

Description

catch my_option.iter().fold(my_val, |x, y| ..y), suggest my_option.map_or(my_val, |x| ..my_val)

Contributor guide

Research direction
Study existing Clippy lints that suggest alternative method calls, then write a new lint that detects the pattern `my option.iter().fold(my val, |x, y| ..y)` and suggests `my option.map or(my val, |x| ..my val)`. Test with various type annotations.
Tech stack
rust
Domain
tooling
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
RustClippy lint development
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70