rust-lang/rust-clippy

Lint `let mut x = x;` where `x` is a function argument

Open

#1,657 opened on Apr 3, 2017

View on GitHubContributor guide
 (4 comments) (1 reaction) (0 assignees)Rust (1,391 forks)batch import
A-lintL-unnecessaryT-middlegood first issue

Repository metrics

Stars
 (10,406 stars)
PR merge metrics
 (PR metrics pending)

Description

The argument should be made mutable instead of rebinding it to mutable.

Contributor guide

Research direction
Find the relevant clippy lint module and add a new lint that detects 'let mut x = x' where x is a function argument. Look at existing lints for patterns.
Tech stack
rust
Domain
devtools
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
RustGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60