rust-lang/rust-clippy

detect #[allow(warnings)] and issue an unsilenceable warning

Open

#1648 opened on Mar 31, 2017

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Rust (10,406 stars) (1,391 forks)batch import
S-needs-discussionT-ASTgood first issue

Description

because if you use clippy, you opt in to warnings, why would you opt out again?

Contributor guide

Tech stack
rust
Domain
toolingdeveloper experience
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
basic Rust knowledgefamiliarity with Clippy
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
The issue requests a new Clippy lint that detects #[allow(warnings)] and emits a warning that cannot be silenced. To implement, one should study how existing lints are defined in Clippy (e.g., in clippy lints/src/) and understand lint attribute handling. The lint should check for the allow(warnings) attribute on items and report a warning with a level that is not suppressible, perhaps using a custom lint level. The challenge is ensuring the lint itself is not disabled by the same attribute. Look into Clippy's lint registration and the Rust compiler's lint infrastructure.