rust-lang/rust-clippy

Lint for denylisted-strings, similar to denylisted-names

Open

#1624 opened on Mar 15, 2017

View on GitHub
 (7 comments) (0 reactions) (0 assignees)Rust (10,406 stars) (1,391 forks)batch import
A-lintT-ASTgood first issue

Description

This would search for specific string literals that are blacklisted, for example "foo", "bar", or "123".

Contributor guide

Tech stack
rust
Domain
tooling
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
3-5 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Rust programmingRust Clippy internalsAST pattern matching
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
The existing `denylisted names` lint is likely implemented in clippy's 'lint' directory, e.g., in `clippy lints/src/denylisted names.rs`. Review that file to understand how it checks for specific names, then adapt it to search for string literals. The new lint should check for literal `"foo"`, `"bar"`, etc., using Rust's AST representation (`ExprKind::Lit`). Consider adding a configuration option for the denylisted strings. See comments in the issue for any additional context.