rust-lang/rust-clippy

should_implement_trait should include ToOwned, FromStr

Open

#1,600 opened on Mar 4, 2017

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Rust (1,391 forks)batch import
C-enhancementL-styleT-middlegood first issue

Repository metrics

Stars
 (10,406 stars)
PR merge metrics
 (Avg merge 19d 22h) (113 merged PRs in 30d)

Description

Also see: servo/rust-url#286.

For FromStr, clippy should recommend that parse methods be renamed to from_str.

Contributor guide

Research direction
Inspect the existing `should implement trait` lint and add `ToOwned` and `FromStr` to the list of traits checked.
Tech stack
rust
Domain
tooling
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Rust
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60