rust-lang/rust-clippy

should_implement_trait should include ToOwned, FromStr

Open

#1600 opened on Mar 4, 2017

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Rust (10,406 stars) (1,391 forks)batch import
C-enhancementL-styleT-middlegood first issue

Description

Also see: servo/rust-url#286.

For FromStr, clippy should recommend that parse methods be renamed to from_str.

Contributor guide

Tech stack
rust
Domain
tooling
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
RustClippyLint implementation
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
45
Research direction
The issue is to extend the should implement trait lint to also check for ToOwned and FromStr. Refer to the existing implementation of should implement trait in clippy lints/src/should implement trait.rs. The linked issue servo/rust url#286 provides additional context. Look at how the lint currently checks for trait implementations and add patterns for FromStr and ToOwned.