rust-lang/rust-clippy

Lint unwrap in drop impls

Open

#1523 opened on Feb 8, 2017

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Rust (10,406 stars) (1,391 forks)batch import
A-lintE-hardL-correctnessT-middlegood first issue

Description

Would it make sense to deny panic-able fns in Drop::drop implementations? It recently came up in https://github.com/diesel-rs/diesel/pull/641#discussion_r100066589.

Contributor guide

Tech stack
rust
Domain
toolingdeveloper experience
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Understanding of Rust's Drop traitFamiliarity with Clippy's lint structure
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Examine Clippy's existing lints like 'unwrap used' to understand the pattern. Review the referenced diesel PR for context. Investigate how to detect panicking functions in Drop implementations within Clippy's lint infrastructure. Look into previous discussions in the issue comments.