rust-lang/rust-clippy

Lint unwrap in drop impls

Open

#1,523 opened on Feb 8, 2017

View on GitHubContributor guide
 (2 comments) (0 reactions) (0 assignees)Rust (1,391 forks)batch import
A-lintE-hardL-correctnessT-middlegood first issue

Repository metrics

Stars
 (10,406 stars)
PR merge metrics
 (PR metrics pending)

Description

Would it make sense to deny panic-able fns in Drop::drop implementations? It recently came up in https://github.com/diesel-rs/diesel/pull/641#discussion_r100066589.

Contributor guide

Research direction
Study existing Clippy lints that check for panics (e.g., `panic` lint) and understand the lint registration system. Then implement a new lint that detects unwrap calls inside `Drop` impls by traversing function bodies of `drop` methods.
Tech stack
rust
Domain
developer experience
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Rust
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60