rust-lang/rust-clippy

Lint on method/struct fields sharing the same name

Open

#1481 opened on Jan 27, 2017

View on GitHub
 (7 comments) (0 reactions) (1 assignee)Rust (10,406 stars) (1,391 forks)batch import
A-lintL-styleT-middlegood first issue

Description

Would it be possible to lint on the situation in which a struct field shares a name with a struct method? For example, in the following situation:

struct Foo {
  bar: i32 
}

impl Foo {
  fn bar(self);
}

Contributor guide

Tech stack
rust
Domain
tooling
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Rust syntaxClippy lint architecture
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
The issue requests a new lint for when a struct field and a method share the same name. To implement, start by studying existing Clippy lints, particularly those that check struct fields or methods. Look at the Clippy contribution guide and the `clippy lints` crate. The lint should detect the pattern shown in the issue and emit a warning. Check if there are any open discussions or alternative approaches in the comments.