rust-lang/rust-clippy

Lint on method/struct fields sharing the same name

Open

#1,481 opened on Jan 27, 2017

View on GitHub
 (7 comments) (0 reactions) (1 assignee)Rust (1,391 forks)batch import
A-lintL-styleT-middlegood first issue

Repository metrics

Stars
 (10,406 stars)
PR merge metrics
 (Avg merge 19d 22h) (113 merged PRs in 30d)

Description

Would it be possible to lint on the situation in which a struct field shares a name with a struct method? For example, in the following situation:

struct Foo {
  bar: i32 
}

impl Foo {
  fn bar(self);
}

Contributor guide

Research direction
Examine existing Clippy lints for name conflicts, such as `shadow unrelated`, to understand the structure. Study how rustc exposes field and method resolution, then implement a new lint that triggers when a struct field and a method share the same name.
Tech stack
rust
Domain
tooling
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Rust
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70