rust-lang/rust-clippy

improve suggestions around `&*` and don't add parenthesis

Open

#1,431 opened on Jan 10, 2017

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Rust (1,391 forks)batch import
C-enhancementL-suggestiongood first issue

Repository metrics

Stars
 (10,406 stars)
PR merge metrics
 (Avg merge 19d 22h) (113 merged PRs in 30d)

Description

~~Is there ever a reason to have an unsized type and ref it instead of having a reference to an unsized type?

I think we should simply suggest to use let p: &str = &*"hello"; instead (and make sure our quoting code erases &* or sth)

E-medium because I'm wary of weird consequences for cases I didn't think about.~~

make sure our quoting code erases &*

Contributor guide

Research direction
Investigate the quoting code in clippy that generates suggestions and ensure that `&*` patterns are not added unnecessarily.
Tech stack
rust
Domain
developer experiencetooling
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
RustGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60