rust-lang/rust-clippy

Refactor the `clippy_lints/src/strings.rs` file

Open

#14,253 opened on Feb 19, 2025

View on GitHub
 (16 comments) (0 reactions) (1 assignee)Rust (10,406 stars) (1,391 forks)batch import
E-help-wantedgood first issue

Description

Description

With the exception of string_add, string_add_assign and string_slice (which share an implementation), all lints in strings.rs could be moved into the methods module in order to share the tree traversal with other method call and function call lints.

Contributor guide

Tech stack
rust
Domain
tooling
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
RustClippy internalsTree traversal in clippy
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
First, review the current lints in `clippy lints/src/strings.rs` and identify which ones (excluding `string add`, `string add assign`, `string slice`) can be moved to the `methods` module. Then, understand the tree traversal pattern used in the `methods` module to integrate the moved lints. Finally, ensure no duplicate functionality and update test expectations accordingly. The issue has 16 comments; check them for maintainer guidance and potential blockers.