rust-lang/rust-clippy

lint long chains of into/float additions/multiplications

Open

#1,243 opened on Sep 25, 2016

View on GitHub
 (13 comments) (0 reactions) (0 assignees)Rust (1,391 forks)batch import
A-lintL-perfT-ASTgood first issue

Repository metrics

Stars
 (10,406 stars)
PR merge metrics
 (Avg merge 19d 22h) (113 merged PRs in 30d)

Description

In generall, (a+b+c)+(d+e+f) is faster to compute than a+b+c+d+e+f, because the former reduces data dependencies, allowing the CPU to run additions in parallel. For float arithmetic, the tree-like addition may improve numerical stability. Suggest inserting parenthesis.

Contributor guide

Research direction
Study existing clippy lints for arithmetic (e.g., `clippy::precedence`) and understand how to add a new lint. Then implement a lint that detects long chains of additions/multiplications and suggests inserting parentheses.
Tech stack
rust
Domain
devtools
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Rust
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50