rust-lang/rust-clippy

lint usage of struct constructors when new/from method is available

Open

#1,216 opened on Sep 5, 2016

View on GitHub
 (7 comments) (0 reactions) (0 assignees)Rust (10,406 stars) (1,391 forks)batch import
A-lintL-styleT-middlegood first issue

Description

if a struct has a new or a from method that does the same as a struct constructor, then that method should be used instead of the struct constructor.

Obviously the usage of a struct constructor inside the new or from method should not be linted.

Contributor guide

Tech stack
rust
Domain
tooling
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Rust programmingClippy contribution guideAST manipulation basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
45
Research direction
Start by reading the clippy documentation for contributing new lints. Look at the `clippy lints` directory for examples of lints that check function calls, such as `new ret no self` (file: clippy lints/src/new ret no self.rs). Understand how to implement a lint pass that checks struct expressions and compares them to available new/from methods. Review the issue comments for any additional design considerations.