rust-lang/rust-clippy

lint usage of struct constructors when new/from method is available

Open

#1,216 opened on Sep 5, 2016

View on GitHub
 (7 comments) (0 reactions) (0 assignees)Rust (1,391 forks)batch import
A-lintL-styleT-middlegood first issue

Repository metrics

Stars
 (10,406 stars)
PR merge metrics
 (Avg merge 19d 22h) (113 merged PRs in 30d)

Description

if a struct has a new or a from method that does the same as a struct constructor, then that method should be used instead of the struct constructor.

Obviously the usage of a struct constructor inside the new or from method should not be linted.

Contributor guide

Research direction
Investigate how to define a new lint in clippy that detects usage of struct constructors when a `new` or `from` method is available. Look at existing lints like `new ret no self` for patterns and study the clippy lint creation guide.
Tech stack
rust
Domain
developer experience
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Rust
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70