rust-lang/rust-clippy

`bool_comparison` should not fire when testing for false

Open

#1,043 opened on Jun 26, 2016

View on GitHub
 (4 comments) (2 reactions) (0 assignees)Rust (10,406 stars) (1,391 forks)batch import
A-lintL-styleS-needs-discussiongood first issue

Description

I think that the bool_comparison lint should not fire when the comparison is var == false because, at least I, find that version much easier to see when quickly scrolling through the code than the !var as it is too simple to miss that single !. However, I'm just putting this here for discussion I'll go turn the lint off in that specific place.

Enjoy your rusty endeavors.

Contributor guide

Tech stack
rust
Domain
toolingdeveloper experience
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
basic rustclippy lint architecture
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
35
Research direction
Examine the bool comparison lint implementation in clippy lints/src/bool comparison.rs. Review the issue comments for any maintainer feedback or prior attempts. The change likely involves adding an exception for `== false` comparisons or adding a configuration option. Implement the change and include tests.