rust-lang/rust-clippy

`bool_comparison` should not fire when testing for false

Open

#1,043 opened on Jun 26, 2016

View on GitHub
 (4 comments) (2 reactions) (0 assignees)Rust (1,391 forks)batch import
A-lintL-styleS-needs-discussiongood first issue

Repository metrics

Stars
 (10,406 stars)
PR merge metrics
 (Avg merge 19d 22h) (113 merged PRs in 30d)

Description

I think that the bool_comparison lint should not fire when the comparison is var == false because, at least I, find that version much easier to see when quickly scrolling through the code than the !var as it is too simple to miss that single !. However, I'm just putting this here for discussion I'll go turn the lint off in that specific place.

Enjoy your rusty endeavors.

Contributor guide

Research direction
Locate the `bool comparison` lint implementation in Clippy's source code and identify where it triggers for comparisons like `== false`. Modify the lint to skip such comparisons, possibly by adding a check for the `false` literal.
Tech stack
rust
Domain
developer experience
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
RustGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75