rust-lang/rust-analyzer

StructuralSearchReplace: next steps

Open

#3186 opened on Feb 17, 2020

View on GitHub
 (35 comments) (2 reactions) (0 assignees)Rust (14,924 stars) (1,726 forks)batch import
A-ideE-hardS-actionablefungood first issue

Description

https://github.com/rust-analyzer/rust-analyzer/pull/3099 implemented initial version of SSR.

This issue collects things we need to do to make this really production-read

@mikhail-m1 any other things I've missed?

Contributor guide

Tech stack
rust
Domain
developer experience
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
over 1 week
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Rust programmingrust analyzer codebasestructural search replacepattern matching
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
20
Research direction
Start by understanding the current SSR implementation from PR #3099 and the matching code at the linked diff. Then, focus on one of the remaining tasks: either improving matching for semantically equivalent transformations (e.g., field order) or adding support for matchers beyond `$expr`. The docs are already done; check the docs/user/features.md for reference.