ruffle-rs/ruffle

Add more image tests

Open

#6,972 opened on May 13, 2022

View on GitHub
 (2 comments) (2 reactions) (0 assignees)Rust (17,394 stars) (932 forks)batch import
A-testsgood first issue

Description

@Aaron1011 was kind enough to add the ability for rendering test images, we should add some more of these, some of which may have caught recent regressions.

  • Fill styles (gradients, bitmaps, w/ transforms)
  • Line styles (including all linestyle2 options, caps, joins, fills)
  • Color transforms (including <0% and >100% testing premultiplied alpha)
  • Masking (including nested masks, AS masks)
  • Text (static, edit texts, outline and device fonts)
  • Drawing API
  • BitmapData (and associated methods)
  • Blend modes (when implemented)
  • Filters (when implemented)

Contributor guide

Tech stack
rust
Domain
testing
Issue type
test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
over 1 week
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Rust basicsfamiliarity with Ruffle's test infrastructure
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
55
Research direction
This issue requests adding more image based rendering tests to catch regressions. The existing test infrastructure is powered by a rendering test image framework added by a previous contributor. To start, look at the existing test files in the repository to understand the patterns. Focus on implementing fill styles, line styles, color transforms, masking, text, and drawing API tests as listed. Review the 'tests' directory and any related rendering test documentation. No linked PRs or assignees are present, so this is freely available.
Add more image tests · ruffle-rs/ruffle#6972 | Good First Issue