ruffle-rs/ruffle

meta: Dependencies declared in multiple crates should be workspace dependencies

Open

#15,460 opened on Mar 6, 2024

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Rust (17,394 stars) (932 forks)batch import
A-buildA-depscode-cleanupgood first issue

Description

This is to reduce the churn of updating them, and the possibility of them getting accidentally out of sync, therefore dupicated (see for example: #15396).

I have a preliminary list of the most duplicated dependency crates - I can comment it here later if you think it'd be easier to get started with that, instead of discovering them on your own.

Yes, this is shameless "new-contributor-bait". :wink:

Contributor guide

Tech stack
rust
Domain
build systembackend
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Familiarity with Rust workspace dependenciesBasic knowledge of Cargo.toml
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80
Research direction
Review the issue description and the preliminary list of duplicated crates (if provided in comments). For each crate, update its Cargo.toml to reference the workspace dependency from the root Cargo.toml instead of duplicating the version. Ensure no version mismatches. Check for any existing PRs or comments that may indicate progress. Refer to the linked issue #15396 for context.